Re: [RFC/PATCH] builtin/blame: darken redundant line information

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 13, 2017, 18:06 UTC
Message-ID: <xmqqy3sv69ut.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kZNXCjBBnzPZLJqPY9S_ovPAegNT0pdCKAMWJH5AQoCCw@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 13 quoted lines

> On Tue, Jun 13, 2017 at 10:33 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Stefan Beller <sbeller@google.com> writes:
>>
>>> But you do not want to (yet)? The goal is not to tell you where the bounds
>>> are, but the goal is to point out that extra care is required for review of
>>> these particular 3 lines.
>>
>> And when you _can_ help users in that "extra care" by pointing out
>> where the boundary is, what is the justification for hiding that
>> information?
> ...
>
> And how many colors would be confusing for the user?

Well, having two "dimmed" for moved lines are not needed if we use the same as context, so we can reduce the colors to just two highlights times two (i.e. old and new).

Having said that,

> I would think we want to start with a simple model ...

would be OK. Let me configure the old-moved and new-moved to the same as context and see if I can live with just a single highlight color.

Thanks.