git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] builtin/blame: darken redundant line information

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 13, 2017, 17:19 UTC
Message-ID
<xmqqo9tr7qkk.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CAGZ79kYV8Ngis=ux50Zs1r5XOBUJ=hw2=8BEkNqk7PiGamX0AA@mail.gmail.com>
Stefan Beller <sbeller@google.com> writes:
Show 23 quoted lines
> Here is what currently happens:
>
>>
>>          context
>>         -B              dim  oldMoved
>>         -B              dim  oldMoved
>>         -B              highlight oldMovedAlternative
>>         -A              highlight oldMovedAlternative
>>         -A              dim  oldMoved
>>         -A              dim  oldMoved
>>          context
>>         +A              dim  newMoved
>>         +A              dim  newMoved
>>         +A              highlight  newMovedAlternative
>>         +B              highlight  newMovedAlternative
>>         +B              dim  newMoved
>>         +B              dim  newMoved
>>          context
>>
>
> So the there is only one "highlight" color in each block.
> There is no separate hightligh-for-ending-block and
> highlight-for-new-block respectively.

I think the adjacentbounds mode is simply broken if that is the design.

In the above simplified case, you can get away with only a single "highlight" color, but you cannot tell where the boundaries are when three or more lines are shuffled, no?

Previous: Stefan BellerNext: Stefan Beller
Message 6 of 19 in “builtin/blame: darken redundant line information”
  1. builtin/blame: darken redundant line informationStefan Beller, Jun 13, 2017
  2. Junio C HamanoJun 13, 2017
  3. Stefan BellerJun 13, 2017
  4. Junio C HamanoJun 13, 2017
  5. Stefan BellerJun 13, 2017
  6. Junio C HamanoJun 13, 2017
  7. Stefan BellerJun 13, 2017
  8. Junio C HamanoJun 13, 2017
  9. Stefan BellerJun 13, 2017
  10. Junio C HamanoJun 13, 2017
  11. Stefan BellerJun 13, 2017
  12. Junio C HamanoJun 13, 2017
  13. Jonathan TanJun 13, 2017
  14. Stefan BellerJun 14, 2017
  15. [PATCHv2] builtin/blame: highlight interesting thingsStefan Beller, Jul 26, 2017
  16. Junio C HamanoJul 26, 2017
  17. Stefan BellerJul 26, 2017
  18. Junio C HamanoJul 27, 2017
  19. Stefan BellerJul 27, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.