Re: [RFC/PATCH] builtin/blame: darken redundant line information

From: Jonathan Tan <jonathantanmy@google.com>
Date: Jun 13, 2017, 23:42 UTC
Message-ID: <20170613164256.1773a62d@twelve2.svl.corp.google.com>
In-Reply-To: <20170613023151.9688-1-sbeller@google.com>

On Mon, 12 Jun 2017 19:31:51 -0700 Stefan Beller <sbeller@google.com> wrote:

Show 10 quoted lines

> When using git-blame lots of lines contain redundant information, for
> example in hunks that consist of multiple lines, the metadata (commit name,
> author, timezone) are repeated. A reader may not be interested in those,
> so darken them. The darkening is not just based on hunk, but actually
> takes the previous lines content for that field to compare to.
> 
> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
> 
>  Example output (blame of blame): http://i.imgur.com/0Y12p2f.png

Looking at this image, how does blame decide what to dim? As it is, I see many identical timestamps (and also from the same commit) not being dimmed. (For example, see the very last line with "2013-01-05 ..." which is identical to the previous line, and I would expect that to be dimmed.)

Also, my preference is to have all-or-nothing dimming (dim the whole line up to and including the time zone if nothing has changed, and dim nothing otherwise) but I know that this is a subjective issue.