Re: [RFC/PATCH] builtin/blame: darken redundant line information

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 13, 2017, 17:48 UTC
Message-ID: <xmqq37b37p9o.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGZ79kZNXCjBBnzPZLJqPY9S_ovPAegNT0pdCKAMWJH5AQoCCw@mail.gmail.com>

Stefan Beller <sbeller@google.com> writes:

Show 35 quoted lines

> On Tue, Jun 13, 2017 at 10:33 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Stefan Beller <sbeller@google.com> writes:
>>
>>> But you do not want to (yet)? The goal is not to tell you where the bounds
>>> are, but the goal is to point out that extra care is required for review of
>>> these particular 3 lines.
>>
>> And when you _can_ help users in that "extra care" by pointing out
>> where the boundary is, what is the justification for hiding that
>> information?
>
> It is very complicated and confusing. Consider this:
>
>>          context
>>         -C
>>          context
>>         -B
>>         -B
>>         -B
>>         -A
>>         -A
>>         -A
>>          context
>>         +A
>>         +A
>>         +A
>>         +C
>>         +B
>>         +B
>>         +B
>>          context
>
> So from your emails I understood you want to markup
> block starts and ends, but in this case C is *both* start
> and end of a block, and has also different blocks around.

I never said "start and end" (you did). I just wanted the boundary of A and B and C clear, so I'd be perfectly happy with:

         context
        +A      dim
        +A      dim
        +A      highlight #1
        +C      highlight #2
        +B      highlight #1
        +B      dim
        +B      dim
         context

You can do that still with only two highlight colors, no?