Re: [PATCH v2 5/7] trace2: remove use of xstrfmt()
Elijah Newren <newren@gmail.com> writes:
Show 12 quoted lines
> On Tue, Aug 25, 2026 at 11:59 AM Derrick Stolee via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>>
> [...]
>>+ const char *redact = ":<REDACTED>";
>>+ char *redacted;
> [...]
>> + memcpy(redacted, arg, prefix_len);
>> + memcpy(redacted + prefix_len, redact, redact_len - 1);
>
> Only copy redact_len - 1 bytes? So only ":<REDACTED" without the
> trailing ">" ? Why?
Yeah, if it were (redact_len + 1) it would have worked better, perhaps?
Show 7 quoted lines
>
>
>> + memcpy(redacted + prefix_len + redact_len - 1, p + at,
>> + suffix_len + 1);
>> + return redacted;
>> }
>>
Junio C Hamano <gitster@pobox.com>