Re: [PATCH] trace2: tolerate failed timestamp formatting
- From
Taylor Blau <ttaylorr@openai.com>
- Date
- Jul 20, 2026, 14:37 UTC
- Message-ID
- <al4yrXXoZiHLwSvE@com-79390>
- In-Reply-To
- <xmqqzezlhgyo.fsf@gitster.g>
On Mon, Jul 20, 2026 at 07:29:51AM -0700, Junio C Hamano wrote:
Show 13 quoted lines
> Derrick Stolee <stolee@gmail.com> writes: > > >> Would it make more sense to fix the xsnprintf()/libintl boundary and > >> treat Trace2 reentrancy separately? I still can't explain why the > >> allocation failed, so there may be another GfW-specific piece I’m > >> missing. > > > > I think that your suggested change has merits and should be pursued. > > I'll explore it a bit to confirm. > > That band-aid may be a good idea, but I would prefer not to see the > conditional in a common source file like 'wrapper.c'. Somewhere > MinGW-specific would be more appropriate, would it not?
Yeah, to be clear, I do not think that putting the '#define' here in 'wrapper.c' is appropriate, and included it in my original email only to demonstrate the shape of the proposed solution.
Thanks, Taylor