Re: [PATCH v2 6/7] trace2: remove use of ALLOC_GROW()
- From
Elijah Newren <newren@gmail.com>
- Date
- Aug 25, 2026, 22:14 UTC
- Message-ID
- <CABPp-BFsSPJutOKManq-55ri=ddBpWLfN16xSNVs9O7+c2z0cg@mail.gmail.com>
- In-Reply-To
- <120cf1967bde4e719a781c391b285c718553ad58.1787684181.git.gitgitgadget@gmail.com>
On Tue, Aug 25, 2026 at 11:57 AM Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com> wrote:
Show 15 quoted lines
> > From: Derrick Stolee <stolee@gmail.com> > > The ALLOC_GROW() helper can call die() on a failed memory allocation. > We need to remove this from the trace2 API code to prevent a recursive > die() handler. > > This helper is used to track the nested region stack. Use a new > skipped_regions member to track how many times a region was entered > without being added to the stack, and decrease that amount as we leave > each region. This allows us to avoid a failure and instead stop > deepening the stack, giving as much nesting behavior as possible without > failing the entire process. > > Signed-off-by: Derrick Stolee <stolee@gmail.com>
Checking out this commit and running
GIT_TRACE2_PERF=1 ./bin-wrappers/git status
dies with
no open regions in thread 'main'
Seems to be fixed by 7/7, though. Maybe a bad splitting?