Re: [PATCH v2 5/7] trace2: remove use of xstrfmt()
- From
Elijah Newren <newren@gmail.com>
- Date
- Aug 25, 2026, 22:14 UTC
- Message-ID
- <CABPp-BHxpt1UBTY5LCn9OFMZ6EtOcUPc-61RMWvjpjDBmv1rzg@mail.gmail.com>
- In-Reply-To
- <7f0bb405ad380fd35ae6381961ac667fd7e5dfd9.1787684181.git.gitgitgadget@gmail.com>
On Tue, Aug 25, 2026 at 11:59 AM Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com> wrote:
>
[...]
>+ const char *redact = ":<REDACTED>"; >+ char *redacted;
[...]
> + memcpy(redacted, arg, prefix_len); > + memcpy(redacted + prefix_len, redact, redact_len - 1);
Only copy redact_len - 1 bytes? So only ":<REDACTED" without the trailing ">" ? Why?
Show 5 quoted lines
> + memcpy(redacted + prefix_len + redact_len - 1, p + at, > + suffix_len + 1); > + return redacted; > } >