Re: What's cooking in git.git (May 2016, #09; Tue, 31) t1308 broken

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 2, 2016, 21:31 UTC
Message-ID: <xmqqwpm7s2ex.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqq1t4ftheu.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 19 quoted lines

> Torsten Bögershausen <tboegi@web.de> writes:
>
>> It seams as  ./t1308-config-set.sh is broken,
>> when the the directory is a soft link:
>>
>> -name=/home/tb/NoBackup/projects/git/git.pu/t/trash
>> directory.t1308-config-set/.gitconfig
>> +name=/home/tb/projects/git/git.pu/t/trash directory.t1308-config-set/.gitconfig
>>  scope=global
>
> It does seem that way.  Somebody is affected by $PWD when we should
> be consistently using the physical / real path.
>
>>
>>  key=foo.bar
>> not ok 28 - iteration shows correct origins
>>
>> I havent't digged further, too many conflicts in the config code, may be
>> somebody knows it directly ?

Perhaps like this, taking hint from the log message of 6eafa6d0 (submodules: don't stumble over symbolic links when cloning recursively, 2012-07-12)?

 t/t1308-config-set.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh
index 065d5eb..1ba9ecb 100755
--- a/t/t1308-config-set.sh
+++ b/t/t1308-config-set.sh
@@ -237,7 +237,7 @@ test_expect_success 'iteration shows correct origins' '
 	key=foo.bar
 	value=from-home
 	origin=file
-	name=$(pwd)/.gitconfig
+	name=$TRASH_DIRECTORY/.gitconfig
 	scope=global
 
 	key=foo.bar