git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t1308: do not get fooled by symbolic links to the source tree

From
Torsten Bögershausen <tboegi@web.de>
Date
Jun 3, 2016, 09:19 UTC
Message-ID
<57514BA8.7020207@web.de>
In-Reply-To
<57512980.1070200@kdbg.org>
On 06/03/2016 08:53 AM, Johannes Sixt wrote:
Show 25 quoted lines
> Am 03.06.2016 um 08:10 schrieb Jeff King:
>> On Fri, Jun 03, 2016 at 08:05:56AM +0200, Johannes Sixt wrote:
>>
>>>> -    name=$(pwd)/.gitconfig
>>>> +    name=$HOME/.gitconfig
>>>
>>> I haven't tested this, yet, but my guess is that this breaks on 
>>> Windows:
>>> test-config will produce C:/foo style path, but the updated test would
>>> expect /c/foo style path. Dscho, do you have an idea how to fix this?
>>
>> Hmm. This should come directly from expand_user_path("~/.gitconfig")
>> which prepends the literal contents of the $HOME variable. It does go
>> through convert_slashes() afterwards, but I don't see any other
>> massaging (but I won't be surprised when you tell me there is some that
>> happens behind the scenes).
>
> Yes, it happens behind the scenes: /c/foo absolute paths are a 
> convention used by the POSIX emulation layer (MSYS). When bash (an 
> MSYS program) runs a non-MSYS program such as git or test-config, it 
> converts the /c/foo paths in the environment (and argument list) to 
> c:/foo style because the non-MSYS programs do not understand the MSYS 
> convention.
>
> -- Hannes

Compiling pu didn't succed: unix_stream_connect is missing in read_cache.c

(And many more in index-heloer.c)
(I thought that the index-helper is only compiled on systems,
   which are known to have unix-sockets and other stuff ?)

After patching that out, t1308 fails: -name=/c/ +name=c:/

Previous: Johannes SixtNext: Johannes Schindelin
Message 13 of 14 in “What's cooking in git.git (May 2016, #09; Tue, 31)”
  1. Junio C HamanoMay 31, 2016
  2. Torsten BögershausenJun 2, 2016
  3. Junio C HamanoJun 2, 2016
  4. Junio C HamanoJun 2, 2016
  5. Jeff KingJun 2, 2016
  6. t1308: do not get fooled by symbolic links to the source treeJunio C Hamano, Jun 2, 2016
  7. Jeff KingJun 2, 2016
  8. Stefan BellerJun 2, 2016
  9. Jeff KingJun 3, 2016
  10. Johannes SixtJun 3, 2016
  11. Jeff KingJun 3, 2016
  12. Johannes SixtJun 3, 2016
  13. Torsten BögershausenJun 3, 2016
  14. Johannes SchindelinJul 14, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.