[PATCH] t1308: do not get fooled by symbolic links to the source tree
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 2, 2016, 22:15 UTC
- Message-ID
- <xmqqeg8fs0dw.fsf_-_@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160602213920.GA13356@sigill.intra.peff.net>
When your $PWD does not match $(/bin/pwd), e.g. you have your copy of the git source tree in one place, point it with a symbolic link, and then "cd" to that symbolic link before running 'make test', one of the tests in t1308 expects that the per-user configuration was reported to have been read from the true path (i.e. relative to the target of such a symbolic link), but the test-config program reports a path relative to $PWD (i.e. the symbolic link).
Instead, expect a path relative to $HOME (aka $TRASH_DIRECTORY), as per-user configuration is read from $HOME/.gitconfig and the test framework sets these shell variables up in such a way to avoid this problem.
Signed-off-by: Junio C Hamano <gitster@pobox.com> ---
> Yeah, I think it is the same issue. I think the most accurate value
> there would probably be $HOME, though.Thanks.
t/t1308-config-set.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh index 065d5eb..cf716b4 100755 --- a/t/t1308-config-set.sh +++ b/t/t1308-config-set.sh @@ -237,7 +237,7 @@ test_expect_success 'iteration shows correct origins' ' key=foo.bar value=from-home origin=file - name=$(pwd)/.gitconfig + name=$HOME/.gitconfig scope=global key=foo.bar
-- 2.9.0-rc1-228-gd00d833