Re: What's cooking in git.git (May 2016, #09; Tue, 31) t1308 broken

From: Jeff King <peff@peff.net>
Date: Jun 2, 2016, 21:39 UTC
Message-ID: <20160602213920.GA13356@sigill.intra.peff.net>
In-Reply-To: <xmqqwpm7s2ex.fsf@gitster.mtv.corp.google.com>

On Thu, Jun 02, 2016 at 02:31:50PM -0700, Junio C Hamano wrote:

Show 20 quoted lines

> Perhaps like this, taking hint from the log message of 6eafa6d0
> (submodules: don't stumble over symbolic links when cloning
> recursively, 2012-07-12)?
> 
>  t/t1308-config-set.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/t/t1308-config-set.sh b/t/t1308-config-set.sh
> index 065d5eb..1ba9ecb 100755
> --- a/t/t1308-config-set.sh
> +++ b/t/t1308-config-set.sh
> @@ -237,7 +237,7 @@ test_expect_success 'iteration shows correct origins' '
>  	key=foo.bar
>  	value=from-home
>  	origin=file
> -	name=$(pwd)/.gitconfig
> +	name=$TRASH_DIRECTORY/.gitconfig
>  	scope=global
>  
>  	key=foo.bar

Yeah, I think it is the same issue. I think the most accurate value there would probably be $HOME, though.

-Peff