Re: [PATCH] git-send-email: fix get_maintainer.pl regression

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 12, 2017, 19:35 UTC
Message-ID: <xmqqwp1r20zx.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <87fu8fddam.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 12 quoted lines

> My "Makefile: replace perl/Makefile.PL with simple make rules" currently
> cooking in pu changes that so that:
>
>  * We always at runtime test for the system CPAN module.
>
>  * In the case of Error.pm we happen to ship a fallback, in the case of
>    Mail::Address etc. we don't and have fallback code, but we could also
>    just ship a copy and remove the fallback code.
>
> This makes more sense, we always "dynamically link" as it were, we'll
> just change the target to (a presumably newer) system module in the case
> of Error.pm if it's found on the system, otherwise use our fallback.

"When to fallback" aside, I think the above makes sense for the send-email simply because we would be replacing "our own" fallback we may need to maintain forever with something with an upstream that we do not have to worry too much about.

A tangent; I thought I heard that use of Error.pm is strongly discouraged several years ago---am I mistaken, or if I am not, perhaps we should start looking into updating the users?

Thanks.