Re: [PATCH] git-send-email: fix get_maintainer.pl regression

From: Alex Bennée <alex.bennee@linaro.org>
Date: Nov 16, 2017, 16:46 UTC
Message-ID: <874lpu189c.fsf@linaro.org>
In-Reply-To: <20171116154814.23785-1-alex.bennee@linaro.org>

Alex Bennée <alex.bennee@linaro.org> writes:

> Getting rid of Mail::Address regressed behaviour with common
> get_maintainer scripts such as the Linux kernel. Fix the missed corner
> case and add a test for it.
>

<snip>

Show 29 quoted lines

> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index 4d261c2a9..0bcd7ab96 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -172,6 +172,27 @@ test_expect_success $PREREQ 'cc trailer with various syntax' '
>  	test_cmp expected-cc commandline1
>  '
>
> +test_expect_success $PREREQ 'setup get_mainter script for cc trailer' "
> +cat >expected-cc-script.sh <<-EOF && chmod +x expected-cc-script.sh
> +#!/bin/sh
> +echo 'One Person <one@example.com> (supporter:THIS (FOO/bar))'
> +echo 'Two Person <two@example.com> (maintainer:THIS THING)'
> +echo 'Third List <three@example.com> (moderated list:THIS THING (FOO/bar))'
> +echo '<four@example.com> (moderated list:FOR THING)'
> +echo 'five@example.com (open list:FOR THING (FOO/bar))'
> +echo 'six@example.com (open list)'
> +EOF
> +"
> +
> +test_expect_success $PREREQ 'cc trailer with get_maintainer output' '
> +	test_commit cc-trailer &&
> +	clean_fake_sendmail &&
> +	git send-email -1 --to=recipient@example.com \
> +		--cc-cmd="$(pwd)/expected-cc-script.sh" \
> +		--smtp-server="$(pwd)/fake.sendmail" &&
> +	test_cmp expected-cc commandline1
> +'
> +

OK I'm afraid I don't fully understand the test harness as this breaks a bunch of other tests. If anyone can offer some pointers on how to fix I'd be grateful.

In the meantime I know the core change works because I tested with:

#+name: send-patches-dry-run #+begin_src sh :results output # temp workaround export PERL5LIB=/home/alex/src/git.git/perl/ git send-email --confirm=never --dry-run --quiet ${mailto} ${series}.patches/* #+end_src

When I sent my last set of kernel patches to the list (the workflow that was broken before by the cc9075067776ebd34cc08f31bf78bb05f12fd879 change landing via my git stable PPA).

-- Alex Bennée