Re: [PATCH] git-send-email: fix get_maintainer.pl regression

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Dec 11, 2017, 19:46 UTC
Message-ID: <CACBZZX58KpQ7=V8GUFfxuMQq_Ar6cmmoXyPx_umUTbU19+0LCw@mail.gmail.com>
In-Reply-To: <20171211172615.jfsjthkvs4itjpcn@laptop>

On Mon, Dec 11, 2017 at 6:26 PM, Thomas Adam <thomas@xteddy.org> wrote:

Show 12 quoted lines

> On Mon, Dec 11, 2017 at 05:13:53PM +0000, Alex Bennée wrote:
>> So have we come to a consensus about the best solution here?
>>
>> I'm perfectly happy to send a reversion patch because to be honest
>> hacking on a bunch of perl to handle special mail cases is not my idea
>> of fun spare time hacking ;-)
>>
>> I guess the full solution is to make Mail::Address a hard dependency?
>
> This is what I was suggesting, and then as a follow-up, addressing the point
> that there's a bunch of require() hacks to also get around needing
> hard-dependencies.

I don't know what the right move is here, but just saying that this could also be built on top of my "Git::Error" wrapper which I added in "Makefile: replace perl/Makefile.PL with simple make rules" which is currently cooking.

I.e. we'd just ship a copy of Email::Valid and Mail::Address in perl/Git/FromCPAN/, use a wrapper to load them, and then we wouldn't need to if/else this at the code level, just always use the module, and it would work even on core perl.