Re: [PATCH] git-send-email: fix get_maintainer.pl regression

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Dec 12, 2017, 11:49 UTC
Message-ID: <87po7kcgiu.fsf@evledraar.gmail.com>
In-Reply-To: <20171212103040.jbgkyet5rapqxi44@laptop>

On Tue, Dec 12 2017, Thomas Adam jotted:

Show 21 quoted lines

> Hi,
>
> On Mon, Dec 11, 2017 at 08:46:46PM +0100, Ævar Arnfjörð Bjarmason wrote:
>> I.e. we'd just ship a copy of Email::Valid and Mail::Address in
>> perl/Git/FromCPAN/, use a wrapper to load them, and then we wouldn't
>> need to if/else this at the code level, just always use the module,
>> and it would work even on core perl.
>
> I disagree with the premise of this, Ævar.  As soon as you go down this route,
> it increases maintenance to ensure we keep up to date with what's on CPAN for
> a tiny edge-case which I don't believe exists.
>
> You may as well just use App::FatPacker.
>
> We're talking about package maintenance here -- and as I said before, there's
> plenty of it around.  For those distributions which ship Git (and hence also
> package git-send-email), the dependencies are already there, too.  I just
> cannot see this being a problem in relying on non-core perl modules.  Every
> perl program does this, and they don't go down this route of having copies of
> various CPAN modules just in case.  So why should we?  We're not a special
> snowflake.

Something like FatPacker wouldn't make sense in this case, we're not packing stuff into an archive, but just dropping them during 'make install', but yes, it's the same idea of shipping our dependencies with us.

I wouldn't argue for doing this from first principles, in general I think we're way too conservative about adding dependencies to git.git, but the general consensus on-list is to do that carefully, that's why we have all this stuff in contrib/, and why we're depending on perl core only.

Users or packagers of git don't care what's normal for perl programs, to them the fact that git-send-email is written in perl is an implementation detail.

The maintenance burden of just shipping some CPAN module as a fallback is trivial, for example we've shipped Error.pm since 2006-ish, and until I sent a patch this month nobody had touched it since 2013.

It's certainly much easier than maintaining a bunch of if/else code ourselves, or maintaining our own stuff purely because we don't want to force people to package perl dependencies for git.