git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1] config.c: fix msvc compile error

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 24, 2018, 18:22 UTC
Message-ID
<xmqqwotkxzn0.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<235ae68c-f764-ba3a-c641-ef5f99507564@drbeat.li>
Beat Bolli <dev+git@drbeat.li> writes:
Show 13 quoted lines
> Hi Jeff
>
> On 24.07.18 17:30, git@jeffhostetler.com wrote:
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>> 
>> In commit fb0dc3bac135e9f6243bd6d293e8c9293c73b9cd code was added
>> to builtin/config.c to define a new function and a forward declaration
>> for an array of unknown size.  This causes a compile error under MSVC.
>> 
>> Reorder the code to forward declare the function instead of the array.
>
> This was already fixed (differently) in
> <20180705183445.30901-1-dev+git@drbeat.li>.

Thanks for saving me from having to dig the list archive myself. Yes, it is already applied to the tip of the topic that originally caused the breakage.

Previous: Beat BolliNext: Beat Bolli
Message 4 of 9 in “config.c: fix msvc compile error”
  1. config.c: fix msvc compile errorgit@jeffhostetler.com, Jul 24, 2018
  2. Junio C HamanoJul 24, 2018
  3. Beat BolliJul 24, 2018
  4. Junio C HamanoJul 24, 2018
  5. Beat BolliJul 24, 2018
  6. Junio C HamanoJul 24, 2018
  7. Beat BolliJul 24, 2018
  8. Taylor BlauJul 24, 2018
  9. Jeff HostetlerJul 25, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.