From: Junio C Hamano Date: Tue, 24 Jul 2018 18:22:11 GMT Subject: Re: [PATCH v1] config.c: fix msvc compile error Message-ID: In-Reply-To: <235ae68c-f764-ba3a-c641-ef5f99507564@drbeat.li> Beat Bolli writes: > Hi Jeff > > On 24.07.18 17:30, git@jeffhostetler.com wrote: >> From: Jeff Hostetler >> >> In commit fb0dc3bac135e9f6243bd6d293e8c9293c73b9cd code was added >> to builtin/config.c to define a new function and a forward declaration >> for an array of unknown size. This causes a compile error under MSVC. >> >> Reorder the code to forward declare the function instead of the array. > > This was already fixed (differently) in > <20180705183445.30901-1-dev+git@drbeat.li>. Thanks for saving me from having to dig the list archive myself. Yes, it is already applied to the tip of the topic that originally caused the breakage.