git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1] config.c: fix msvc compile error

From
Taylor Blau <me@ttaylorr.com>
Date
Jul 24, 2018, 19:56 UTC
Message-ID
<20180724195637.GA97109@syl.attlocal.net>
In-Reply-To
<20180724153010.6693-1-git@jeffhostetler.com>
On Tue, Jul 24, 2018 at 03:30:10PM +0000, git@jeffhostetler.com wrote:
Show 5 quoted lines
> From: Jeff Hostetler <jeffhost@microsoft.com>
>
> In commit fb0dc3bac135e9f6243bd6d293e8c9293c73b9cd code was added
> to builtin/config.c to define a new function and a forward declaration
> for an array of unknown size.  This causes a compile error under MSVC.

Thanks for spending time fixing that. fb0dc3bac1 (builtin/config.c: support `--type=<type>` as preferred alias for `--<type>`, 2018-04-18) is from me, so I owe you an extra thanks for patching up mistakes :-).

As others have noted in this thread, another patch was sent into similar effect, which has already been queued, and I agree that we should prefer that, since it's further along.

Thanks, Taylor

Previous: Beat BolliNext: Jeff Hostetler
Message 8 of 9 in “config.c: fix msvc compile error”
  1. config.c: fix msvc compile errorgit@jeffhostetler.com, Jul 24, 2018
  2. Junio C HamanoJul 24, 2018
  3. Beat BolliJul 24, 2018
  4. Junio C HamanoJul 24, 2018
  5. Beat BolliJul 24, 2018
  6. Junio C HamanoJul 24, 2018
  7. Beat BolliJul 24, 2018
  8. Taylor BlauJul 24, 2018
  9. Jeff HostetlerJul 25, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.