Re: [PATCH] i18n: fix mistakes in translated strings

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 23, 2018, 21:28 UTC
Message-ID: <xmqqwosghiw8.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180823210056.27489-1-jn.avila@free.fr>

Jean-Noël Avila <jn.avila@free.fr> writes:

> -			die(_("run_command returned non-zero status while"
> +			die(_("run_command returned non-zero status while "
>  				"recursing in the nested submodules of %s\n."),

Obviously good.

Show 10 quoted lines

> diff --git a/config.c b/config.c
> index 9a0b10d4bc..3461993f0a 100644
> --- a/config.c
> +++ b/config.c
> @@ -124,7 +124,7 @@ static const char include_depth_advice[] = N_(
>  "	%s\n"
>  "from\n"
>  "	%s\n"
> -"Do you have circular includes?");
> +"This might be due to circular includes.");

OK.

Show 10 quoted lines

> diff --git a/sequencer.c b/sequencer.c
> index 65d371c746..84bf598c3e 100644
> --- a/sequencer.c
> +++ b/sequencer.c
> @@ -720,7 +720,7 @@ static const char *read_author_ident(struct strbuf *buf)
>  	/* dequote values and construct ident line in-place */
>  	for (in = buf->buf; i < 3 && in - buf->buf < buf->len; i++) {
>  		if (!skip_prefix(in, keys[i], (const char **)&in)) {
> -			warning(_("could not parse '%s' (looking for '%s'"),
> +			warning(_("could not parse '%s' (looking for '%s')"),

Good.  Thanks.