git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] i18n: fix dangling dot in die() messages

From
Jean-Noel Avila <jn.avila@free.fr>
Date
Sep 4, 2018, 14:18 UTC
Message-ID
<20180904141816.26398-1-jn.avila@free.fr>
In-Reply-To
<CANYiYbHmU=j+MwLTumJ+BK_0msyPBeux92wF8VqL9J04VOc-FQ@mail.gmail.com>
Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
---
It is not clear what the style guide for messages is.
 builtin/submodule--helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index b56028ba9d..a011abfd7c 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -521,7 +521,7 @@ static void runcommand_in_submodule_cb(const struct cache_entry *list_item,
 		printf(_("Entering '%s'\n"), displaypath);
 
 	if (info->argv[0] && run_command(&cp))
-		die(_("run_command returned non-zero status for %s\n."),
+		die(_("run_command returned non-zero status for %s"),
 			displaypath);
 
 	if (info->recursive) {
@@ -543,7 +543,7 @@ static void runcommand_in_submodule_cb(const struct cache_entry *list_item,
 
 		if (run_command(&cpr))
 			die(_("run_command returned non-zero status while "
-				"recursing in the nested submodules of %s\n."),
+				"recursing in the nested submodules of %s"),
 				displaypath);
 	}
 
-- 
2.18.0
Previous: Jiang XinNext: Ævar Arnfjörð Bjarmason
Message 6 of 11 in “i18n: fix mistakes in translated strings”
  1. i18n: fix mistakes in translated stringsJean-Noël Avila, Aug 23, 2018
  2. Junio C HamanoAug 23, 2018
  3. Jean-Noël AVILASep 3, 2018
  4. [L10N] Kickoff for Git 2.19.0 round 2Jiang Xin, Sep 4, 2018
  5. Jiang XinSep 4, 2018
  6. i18n: fix dangling dot in die() messagesJean-Noel Avila, Sep 4, 2018
  7. Ævar Arnfjörð BjarmasonSep 4, 2018
  8. Jean-Noël AvilaSep 4, 2018
  9. Junio C HamanoSep 4, 2018
  10. Duy NguyenSep 4, 2018
  11. Junio C HamanoSep 4, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.