git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] i18n: fix mistakes in translated strings

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 4, 2018, 19:32 UTC
Message-ID
<xmqqr2i983ev.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<CANYiYbHmU=j+MwLTumJ+BK_0msyPBeux92wF8VqL9J04VOc-FQ@mail.gmail.com>
Jiang Xin <worldhello.net@gmail.com> writes:
Show 17 quoted lines
> Jean-Noël Avila <jn.avila@free.fr> 于2018年8月24日周五 上午5:02写道:
>> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
>> index 2bcc70fdfe..b56028ba9d 100644
>> --- a/builtin/submodule--helper.c
>> +++ b/builtin/submodule--helper.c
>> @@ -542,7 +542,7 @@ static void runcommand_in_submodule_cb(const struct cache_entry *list_item,
>>                 argv_array_pushv(&cpr.args, info->argv);
>>
>>                 if (run_command(&cpr))
>> -                       die(_("run_command returned non-zero status while"
>> +                       die(_("run_command returned non-zero status while "
>>                                 "recursing in the nested submodules of %s\n."),
>
> Any specific reason to put a period after newline?
> And there is another mistake just above this one:
>
>     "run_command returned non-zero status for %s\n."
Embarrassing X-<

These are not something the "fix" introduces (rather it is what it still misses), though.

Previous: Duy Nguyen
Message 11 of 11 in “i18n: fix mistakes in translated strings”
  1. i18n: fix mistakes in translated stringsJean-Noël Avila, Aug 23, 2018
  2. Junio C HamanoAug 23, 2018
  3. Jean-Noël AVILASep 3, 2018
  4. [L10N] Kickoff for Git 2.19.0 round 2Jiang Xin, Sep 4, 2018
  5. Jiang XinSep 4, 2018
  6. i18n: fix dangling dot in die() messagesJean-Noel Avila, Sep 4, 2018
  7. Ævar Arnfjörð BjarmasonSep 4, 2018
  8. Jean-Noël AvilaSep 4, 2018
  9. Junio C HamanoSep 4, 2018
  10. Duy NguyenSep 4, 2018
  11. Junio C HamanoSep 4, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.