Re: [PATCH] i18n: fix dangling dot in die() messages
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Sep 4, 2018, 15:05 UTC
- Message-ID
- <CACBZZX6Bm-xOO-mvDzmRAA9Xu6HrBr5z+39dp4t6fTTCmNHKbQ@mail.gmail.com>
- In-Reply-To
- <20180904141816.26398-1-jn.avila@free.fr>
On Tue, Sep 4, 2018 at 4:59 PM Jean-Noel Avila <jn.avila@free.fr> wrote:
Your commit message says "dangling dot"...
Show 10 quoted lines
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index b56028ba9d..a011abfd7c 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -521,7 +521,7 @@ static void runcommand_in_submodule_cb(const struct cache_entry *list_item,
> printf(_("Entering '%s'\n"), displaypath);
>
> if (info->argv[0] && run_command(&cp))
> - die(_("run_command returned non-zero status for %s\n."),
> + die(_("run_command returned non-zero status for %s"),...but here and below you're also removing the newline. Is this intended, and does it work as desired afterwards? I.e. were we just ignoring the \n?
Show 15 quoted lines
> displaypath);
>
> if (info->recursive) {
> @@ -543,7 +543,7 @@ static void runcommand_in_submodule_cb(const struct cache_entry *list_item,
>
> if (run_command(&cpr))
> die(_("run_command returned non-zero status while "
> - "recursing in the nested submodules of %s\n."),
> + "recursing in the nested submodules of %s"),
> displaypath);
> }
>
> --
> 2.18.0
>