git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t: use LF variable defined in the test harness

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 3, 2019, 21:11 UTC
Message-ID
<xmqqwoeprsp1.fsf@gitster-ct.c.googlers.com>

A few test scripts assign a single LF to $LF, but that is already given by test-lib.sh to everybody.

Remove the unnecessary reassignment.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/t3404-rebase-interactive.sh | 2 --
 t/t4013-diff-various.sh       | 3 ---
 t/t5515-fetch-merge-logic.sh  | 3 ---
 3 files changed, 8 deletions(-)
diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
index 461dd539ff..31114d0bbb 100755
--- a/t/t3404-rebase-interactive.sh
+++ b/t/t3404-rebase-interactive.sh
@@ -155,8 +155,6 @@ test_expect_success 'rebase -x with empty command fails' '
 	test_i18ncmp expected actual
 '
 
-LF='
-'
 test_expect_success 'rebase -x with newline in command fails' '
 	test_when_finished "git rebase --abort ||:" &&
 	test_must_fail env git rebase -x "a${LF}b" @ 2>actual &&
diff --git a/t/t4013-diff-various.sh b/t/t4013-diff-various.sh
index a9054d2db1..5ac94b390d 100755
--- a/t/t4013-diff-various.sh
+++ b/t/t4013-diff-various.sh
@@ -7,9 +7,6 @@ test_description='Various diff formatting options'
 
 . ./test-lib.sh
 
-LF='
-'
-
 test_expect_success setup '
 
 	GIT_AUTHOR_DATE="2006-06-26 00:00:00 +0000" &&
diff --git a/t/t5515-fetch-merge-logic.sh b/t/t5515-fetch-merge-logic.sh
index e55d8474ef..961eb35c99 100755
--- a/t/t5515-fetch-merge-logic.sh
+++ b/t/t5515-fetch-merge-logic.sh
@@ -12,9 +12,6 @@ GIT_TEST_PROTOCOL_VERSION=
 
 . ./test-lib.sh
 
-LF='
-'
-
 test_expect_success setup '
 	GIT_AUTHOR_DATE="2006-06-26 00:00:00 +0000" &&
 	GIT_COMMITTER_DATE="2006-06-26 00:00:00 +0000" &&
Next: Taylor Blau
Message 1 of 10 in “t: use LF variable defined in the test harness”
  1. t: use LF variable defined in the test harnessJunio C Hamano, Sep 3, 2019
  2. Taylor BlauSep 4, 2019
  3. Junio C HamanoSep 5, 2019
  4. Jeff KingSep 5, 2019
  5. Junio C HamanoSep 5, 2019
  6. t: use common $SQ variableDenton Liu, Sep 5, 2019
  7. Taylor BlauSep 5, 2019
  8. Taylor BlauSep 5, 2019
  9. Denton LiuSep 6, 2019
  10. Taylor BlauSep 5, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.