git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t: use common $SQ variable

From
Taylor Blau <me@ttaylorr.com>
Date
Sep 5, 2019, 22:27 UTC
Message-ID
<20190905222736.GA29792@syl.local>
In-Reply-To
<20190905222526.GA29743@syl.local>
On Thu, Sep 05, 2019 at 06:25:26PM -0400, Taylor Blau wrote:
Show 23 quoted lines
> On Thu, Sep 05, 2019 at 03:10:05PM -0700, Denton Liu wrote:
> > In many test scripts, there are bespoke definitions of the single quote
> > that are some variation of this:
> >
> >     SQ="'"
> >
> > Define a common $SQ variable in test-lib.sh and replace all usages of
> > these bespoke variables with the common one.
> >
> > This change was done by running `git grep =\"\'\" t/` and
> > `git grep =\\\\\'` and manually changing the resulting definitions and
> > corresponding usages.
> > Signed-off-by: Denton Liu <liu.denton@gmail.com>
> > ---
> >
> > [whoops, forgot to include the mailing list in the last email]
> >
> > Sorry, I wrote this patch up before I saw the email about leaving this
> > as #leftoverbits. No point in letting it go to waste, though.
>
> Thanks for doing this. I marked it as '#leftoverbits' in case anybody
> hosting an Outreachy intern might be interested in having something
> small for a newcomer to dip their toes into sending to the mailing list.

Oh, how silly of me. I was thinking about [1], which I said would be good #leftoverbits material. This thread was tagged by Junio, not me. The rest of my point stands, though ;).

Show 7 quoted lines
> But, there's no shortage of other such tasks, I'd assume, so it's good
> that you cleaned these up.
>
> Both of your 'git grep' invocations look correct to me, so the patch
> below looks like an obviously-correct result. Thanks.
>
> -Taylor

Thanks, Taylor

[1]: https://public-inbox.org/git/20190904212121.GB20904@syl.local/
Previous: Taylor BlauNext: Denton Liu
Message 8 of 10 in “t: use LF variable defined in the test harness”
  1. t: use LF variable defined in the test harnessJunio C Hamano, Sep 3, 2019
  2. Taylor BlauSep 4, 2019
  3. Junio C HamanoSep 5, 2019
  4. Jeff KingSep 5, 2019
  5. Junio C HamanoSep 5, 2019
  6. t: use common $SQ variableDenton Liu, Sep 5, 2019
  7. Taylor BlauSep 5, 2019
  8. Taylor BlauSep 5, 2019
  9. Denton LiuSep 6, 2019
  10. Taylor BlauSep 5, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.