Re: [PATCH] t: use common $SQ variable

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 5, 2019, 22:25 UTC
Message-ID: <20190905222526.GA29743@syl.local>
In-Reply-To: <0598bbf4d0b2cb07ff6f06f904cbdd3f5a3ae1af.1567721303.git.liu.denton@gmail.com>

On Thu, Sep 05, 2019 at 03:10:05PM -0700, Denton Liu wrote:

Show 18 quoted lines

> In many test scripts, there are bespoke definitions of the single quote
> that are some variation of this:
>
>     SQ="'"
>
> Define a common $SQ variable in test-lib.sh and replace all usages of
> these bespoke variables with the common one.
>
> This change was done by running `git grep =\"\'\" t/` and
> `git grep =\\\\\'` and manually changing the resulting definitions and
> corresponding usages.
> Signed-off-by: Denton Liu <liu.denton@gmail.com>
> ---
>
> [whoops, forgot to include the mailing list in the last email]
>
> Sorry, I wrote this patch up before I saw the email about leaving this
> as #leftoverbits. No point in letting it go to waste, though.

Thanks for doing this. I marked it as '#leftoverbits' in case anybody hosting an Outreachy intern might be interested in having something small for a newcomer to dip their toes into sending to the mailing list.

But, there's no shortage of other such tasks, I'd assume, so it's good that you cleaned these up.

Both of your 'git grep' invocations look correct to me, so the patch below looks like an obviously-correct result. Thanks.

-Taylor