Re: [PATCH] t: use LF variable defined in the test harness

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 5, 2019, 19:34 UTC
Message-ID: <xmqqmufipmfp.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190905184716.GA12647@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 7 quoted lines

> On Thu, Sep 05, 2019 at 11:17:57AM -0700, Junio C Hamano wrote:
>
>> Somebody may want to go clean-up the use of various $sq and $SQ
>> locally defined by giving a unified $SQ in test-lib.sh, by the way.
>
> Maybe good #leftoverbits material, since we may have Outreachy
> applications coming up soon.

OK, then I'd refrain from doing it as a lunchtime hack myself ;-)

 * Find sq=, $sq and ${sq} case insensitively in t/.  If there is
   any use of $SQ that does not want a single quote in it, abort
   the whole thing.  Otherwise proceed.

 * Introduce an assignment SQ=\' in t/test-lib.sh, next to where LF
   is assigned to.  Replace all uses you found in #1 with reference
   to $SQ.

#leftoverbits.