Re: [PATCH 0/7] Sort lists and add static-analysis

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 17, 2021, 18:05 UTC
Message-ID: <xmqqwnu5wt8z.fsf@gitster.g>
In-Reply-To: <cover.1615856156.git.liu.denton@gmail.com>

Denton Liu <liu.denton@gmail.com> writes:

Show 13 quoted lines

> As a follow-up to [0], sort some file lists and create a static-analysis
> check to ensure that those lists don't ever become un-sorted.
>
> [0]: https://lore.kernel.org/git/nycvar.QRO.7.76.6.2010081156350.50@tvgsbejvaqbjf.bet/
>
> Denton Liu (7):
>   Makefile: mark 'check-builtins' as a .PHONY target
>   Makefile: ASCII-sort LIB_OBJS
>   builtin.h: ASCII-sort list of functions
>   test-tool.h: ASCII-sort list of functions
>   Makefile: add 'check-sort' target
>   ci/run-static-analysis.sh: make check-builtins
>   ci/run-static-analysis.sh: make check-sort

I'd expect that the series would be structured better if we

 - move #6 (static-analysis runs check-builtins) earlier, perhaps to
   the front of the series, as there is nothing to fix to make the
   check pass.

 - merge #7 into #5.

I've also left comments on a few individual steps.

Thanks for working on it.

Show 7 quoted lines

>  Makefile                  | 30 ++++++++++++++++++++++++++++--
>  builtin.h                 | 22 +++++++++++-----------
>  check-sort.perl           | 31 +++++++++++++++++++++++++++++++
>  ci/run-static-analysis.sh |  2 +-
>  t/helper/test-tool.h      |  6 +++---
>  5 files changed, 74 insertions(+), 17 deletions(-)
>  create mode 100755 check-sort.perl