Re: [PATCH 5/7] Makefile: add 'check-sort' target

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mar 17, 2021, 18:16 UTC
Message-ID: <87o8fhzlw0.fsf@evledraar.gmail.com>
In-Reply-To: <xmqq1rcdy7zo.fsf@gitster.g>

On Wed, Mar 17 2021, Junio C Hamano wrote:

Show 23 quoted lines

> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>>> +	./check-sort.perl '\t\{ "[^"]*",' <git.c
>>
>> This last one you can IMO be done better as (or if we want to be more
>> anal, we could make git die on startup if it's not true):
>>     
>>     diff --git a/t/t0012-help.sh b/t/t0012-help.sh
>>     index 5679e29c62..5bd2ebceca 100755
>>     --- a/t/t0012-help.sh
>>     +++ b/t/t0012-help.sh
>>     @@ -77,6 +77,11 @@ test_expect_success 'generate builtin list' '
>>             git --list-cmds=builtins >builtins
>>      '
>>      
>>     +test_expect_success 'list of builtins in git.c should be sorted' '
>>     +       sort builtins >sorted &&
>>     +       test_cmp sorted builtins
>>     +'
>
> "LANG=C LC_ALL=C sort ..."
>
> I like this 100% better than the original ;-)

We don't need to use "LANG=C LC_ALL=C sort", the test-lib.sh sets that already, so just "sort" works consistently.

It's also why with GETTEXT_POISON gone we can just "grep" output, instead of worrying that it may be in the user's locale.