Re: [PATCH 5/7] Makefile: add 'check-sort' target

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 17, 2021, 17:59 UTC
Message-ID: <xmqq5z1py844.fsf@gitster.g>
In-Reply-To: <5088e93d76e44de9d079b7b2296b8c810828a2f5.1615856156.git.liu.denton@gmail.com>

Denton Liu <liu.denton@gmail.com> writes:

> +	./check-sort.perl 'int cmd_[^(]*\(' <builtin.h
> +	./check-sort.perl 'int cmd__[^(]*\(' <t/helper/test-tool.h

These two are trivial to see.

> +	./check-sort.perl '\t\{ "[^"]*",' <git.c

This is too brittle to be acceptable. It FORBIDS us from introducing initialization for another table to the file.

I won't participate in the bikeshedding of how the Perl script would be best written ;-)

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.