Re: [PATCH 5/7] Makefile: add 'check-sort' target

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 17, 2021, 21:48 UTC
Message-ID: <CAPig+cRk-fCLFtug47w3trYQFiPzZ3bD4g11Qu4fTd3Fh6_bCQ@mail.gmail.com>
In-Reply-To: <YFI9QzKMKLMXYoyz@coredump.intra.peff.net>

On Wed, Mar 17, 2021 at 1:34 PM Jeff King <peff@peff.net> wrote:

> TBH, I'm a little on the fence on whether automatically checking this is
> even worth the hassle. Doing the make function above was a fun
> diversion, but already I think this discussion has taken more time than
> people actually spend resolving conflicts on unsorted Makefile lists.

I had the same reaction. Like you, I jumped in for the fun diversion. It allowed me to flex my Perl muscle a bit which has atrophied, but an out-of-order item here and there is such a minor concern, especially since they don't impact correctness, that I worry that such a CI job would be more hassle than it's worth. Making the feedback loop tighter, as discussed elsewhere in this thread, makes the idea of the automated check a bit more palatable.