Re: [PATCH v8 2/3] unit tests: add TAP unit test framework
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 11, 2023, 21:42 UTC
- Message-ID
- <xmqqwmvskf8t.fsf@gitster.g>
- In-Reply-To
- <00d3c95a81449bf49c4ce992d862d7a858691840.1696889530.git.steadmon@google.com>
Josh Steadmon <steadmon@google.com> writes:
> + /* Initialized strbufs should always have a non-NULL buffer */ > + if (buf->buf == NULL) > + return 0;
This upsets Coccinelle (equals-null). I'll queue this on top for now to work around CI breakage.
Thanks.
----- >8 ----- Subject: [PATCH] SQUASH???
Coccinelle suggested style fix. --- t/unit-tests/t-strbuf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/unit-tests/t-strbuf.c b/t/unit-tests/t-strbuf.c index c2fcb0cbd6..8388442426 100644 --- a/t/unit-tests/t-strbuf.c +++ b/t/unit-tests/t-strbuf.c @@ -28,7 +28,7 @@ static void setup_populated(void (*f)(struct strbuf*, void*), char *init_str, vo static int assert_sane_strbuf(struct strbuf *buf) { /* Initialized strbufs should always have a non-NULL buffer */ - if (buf->buf == NULL) + if (!buf->buf) return 0; /* Buffers should always be NUL-terminated */ if (buf->buf[buf->len] != '\0')
-- 2.42.0-345-gaab89be2eb