Re: [PATCH v10 1/3] unit tests: Add a project plan document
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 9, 2023, 23:15 UTC
- Message-ID
- <xmqq1qcyzfgp.fsf@gitster.g>
- In-Reply-To
- <f706ba9b682e7c4070d49086ad3af582bf269c79.1699555664.git.steadmon@google.com>
Josh Steadmon <steadmon@google.com> writes:
Show 17 quoted lines
> In our current testing environment, we spend a significant amount of > effort crafting end-to-end tests for error conditions that could easily > be captured by unit tests (or we simply forgo some hard-to-setup and > rare error conditions). Describe what we hope to accomplish by > implementing unit tests, and explain some open questions and milestones. > Discuss desired features for test frameworks/harnesses, and provide a > comparison of several different frameworks. Finally, document our > rationale for implementing a custom framework. > > Co-authored-by: Calvin Wan <calvinwan@google.com> > Signed-off-by: Calvin Wan <calvinwan@google.com> > Signed-off-by: Josh Steadmon <steadmon@google.com> > --- > Documentation/Makefile | 1 + > Documentation/technical/unit-tests.txt | 240 +++++++++++++++++++++++++ > 2 files changed, 241 insertions(+) > create mode 100644 Documentation/technical/unit-tests.txt
Looks good. I'll downcase "Add" on the title to match what I have in my tree, but otherwise it looks OK to me. Let's see if we can mark this round ready for 'next' and check if we hear complaints.
I have to make sure I do not forget about the other topic that builds on top of this one.
Thanks.