Re: [PATCH v2] launch_editor: waiting message on error

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 12, 2024, 15:46 UTC
Message-ID: <xmqqwmp2posk.fsf@gitster.g>
In-Reply-To: <d485c4cd-f963-45b7-9fa6-801738c7c066@gmail.com>

Rubén Justo <rjusto@gmail.com> writes:

Show 14 quoted lines

> On Wed, Apr 10, 2024 at 08:44:25AM -0700, Junio C Hamano wrote:
>...
>> It happens ONLY when the error message the editor itself emits
>> (which comes later on the same line as "We are waiting for your
>> editor...") without terminating newline itself.  Otherwise, we'd
>> have
>> 
>>     We are waiting ... THE EDITOR SAYS I FAILED
>>     _
>> 
>> on the screen, and the cursor is at the _ position.  term_clear_line()
>> would not clear anything.
>
> Not with a careless editor:

That is why I said "Otherwise". Of course, a broken editor would give broken output. What else is new? And more importantly, if you wrote such an editor, would you release it in such a buggy form to the outside world? Does it still look like a problem worth spending our brain cycles on?