Re: [PATCH v4] launch_editor: waiting message on error

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 15, 2024, 18:44 UTC
Message-ID: <xmqqedb6mpns.fsf@gitster.g>
In-Reply-To: <8ef912a9-78f2-411a-a055-f86f69d78b90@gmail.com>

Rubén Justo <rjusto@gmail.com> writes:

Show 14 quoted lines

> - term_clear_line() is now used in all cases as it is unlikely that any
>   sane editor emits an error message without ending it with a newline.
>
>   This:
>
> 	$ GIT_EDITOR=false git commit -a
> 	hint: Waiting for your editor to close the file... error: There was a problem with the editor 'false'.
> 	Please supply the message using either -m or -F option.
>
>   becomes:
>
> 	$ GIT_EDITOR=false git commit -a
> 	error: There was a problem with the editor 'false'.
> 	Please supply the message using either -m or -F option.

Nobody uses 'false' as their editor, but as you said ':cq' in vim may be a real-world example of a use case that may benefit from this change.

Will queue.  Thanks.