Re: [PATCH v4] launch_editor: waiting message on error

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 15, 2024, 17:20 UTC
Message-ID: <xmqqa5lupmo7.fsf@gitster.g>
In-Reply-To: <beebf170-31d0-4ecf-b029-d6bc499f6da8@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

> As I've said before I'm not sure how likely that is as I think the
> editor will probably have printed a message if there was an
> error. Assuming the message from the editor ends with a newline the
> proposed change wont do any harm so I don't object to it.

Yup, I think it is a no-op for a well-behaving editor that emits an error message with terminating newline. An editor that leaves its own error message incomplete, its error message together with our "we are waiting" will be erased together, but we probably do not care for such an editor. If an editor silently errors out, then this will still clear "we are waiting" we printed earlier and say "there was a problem", which is what we want to see happen.

So, this looks good to me; let's queue it.

Thanks, both.