Re: [PATCH v2] launch_editor: waiting message on error

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 12, 2024, 17:35 UTC
Message-ID: <xmqqbk6emql1.fsf@gitster.g>
In-Reply-To: <40075168-24d8-4c46-89fb-30fe2ab2581b@gmail.com>

Rubén Justo <rjusto@gmail.com> writes:

> Yes, but I also see it from another perspective;  I don't want to worry
> about a possible inconvenience.  And since it is perhaps an unexpected
> precaution, for a future reviewer, hence the explicit comment in the
> code.

But then the comment should say it only matters if the editor left its message incomplete, shouldn't it? If the editor did the right thing and terminated its message before it exits with a newline, the extra LF we emit after it will only waste the vertical screen real estate.