Re: [PATCH v2 00/21] Various memory leak fixes
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 27, 2024, 17:38 UTC
- Message-ID
- <xmqqwmnf9mto.fsf@gitster.g>
- In-Reply-To
- <ZlQr11P_C-KyO2DF@tanuki>
Patrick Steinhardt <ps@pks.im> writes:
Show 18 quoted lines
> Indeed. The following diff fixes the leak: > > diff --git a/builtin/update-ref.c b/builtin/update-ref.c > index 7d2a419230..e54be9c429 100644 > --- a/builtin/update-ref.c > +++ b/builtin/update-ref.c > @@ -130,6 +130,8 @@ static char *parse_next_arg(const char **next) > > if (arg.len) > return strbuf_detach(&arg, NULL); > + > + strbuf_release(&arg); > return NULL; > } > > > Karthik is out of office this week, so you may want to add this as a > "SQUASH???" commit on top of his topic branch to make "seen" pass.
Alright. Thanks.
Show 9 quoted lines
>> Also >> >> https://github.com/git/git/actions/runs/9231313414/job/25401102951 >> >> shows that t1460-refs-migrate fails on Windows. > > Hm, this one is curious. There are no leak logs at all, and the exit > code is 139. Might be SIGSEGV, indicating that something else is going > on here than a memory leak.
Sorry, I wasn't clear enough. I do not suspect this is about leaks (and the failing job on Windows is not about leaks).