[PATCH v3 14/21] builtin/credential: clear credential before exit
- From
Patrick Steinhardt <ps@pks.im>
- Date
- May 27, 2024, 11:46 UTC
- Message-ID
- <265665fe6cb7dc56bb637624910369f2bd0525e8.1716810168.git.ps@pks.im>
- In-Reply-To
- <cover.1716810168.git.ps@pks.im>
We never release memory associated with `struct credential`. Fix this and mark the corresponding test as leak free.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- builtin/credential.c | 2 ++ t/t0300-credentials.sh | 2 ++ 2 files changed, 4 insertions(+)
diff --git a/builtin/credential.c b/builtin/credential.c index 5100d441f2..b72e76dd9a 100644 --- a/builtin/credential.c +++ b/builtin/credential.c @@ -39,5 +39,7 @@ int cmd_credential(int argc, const char **argv, const char *prefix UNUSED) } else { usage(usage_msg); } + + credential_clear(&c); return 0; } diff --git a/t/t0300-credentials.sh b/t/t0300-credentials.sh index 432f029d48..6a76b7fdbd 100755 --- a/t/t0300-credentials.sh +++ b/t/t0300-credentials.sh @@ -1,6 +1,8 @@ #!/bin/sh test_description='basic credential helper tests' + +TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh . "$TEST_DIRECTORY"/lib-credential.sh
-- 2.45.1.246.gb9cfe4845c.dirty