Re: [PATCH 12/20] config: plug various memory leaks
- From
Patrick Steinhardt <ps@pks.im>
- Date
- May 24, 2024, 08:55 UTC
- Message-ID
- <ZlBV-QtqoNX-7m8a@tanuki>
- In-Reply-To
- <ZlA6jZmKomOu1p_S@tanuki>
On Fri, May 24, 2024 at 08:58:21AM +0200, Patrick Steinhardt wrote:
Show 34 quoted lines
> On Thu, May 23, 2024 at 10:13:24AM -0700, Junio C Hamano wrote: > > Patrick Steinhardt <ps@pks.im> writes: > > The "message" part in it says that it is encoded in iso-8859-1: > > > > --ovDSRLSkA00eIgbN > > Content-Type: text/plain; charset=iso-8859-1 > > Content-Disposition: inline > > Content-Transfer-Encoding: quoted-printable > > > > ... > > diff --git a/t/t4210-log-i18n.sh b/t/t4210-log-i18n.sh > > index 75216f19ce..7120030b5c 100755 > > --- a/t/t4210-log-i18n.sh > > +++ b/t/t4210-log-i18n.sh > > @@ -1,6 +1,8 @@ > > #!/bin/sh > > =20 > > test_description=3D'test log with i18n features' > > + > > +TEST_PASSES_SANITIZE_LEAK=3Dtrue > > . ./lib-gettext.sh > > =20 > > # two forms of =E9 > > > > But the source in t/t4210-log-i18n.sh actually is written in UTF-8. > > The thing is, the "-u" option (recode into utf-8" is supposed to be > > the default for "git am", and it is passed down to the underlying > > mailinfo machinery in builtin/am.c:parse_mail(). > > > > But apparently that is not working correctly. I see in the patch an > > unrecoded byte E9 in the resulting patch file that is fed to the > > underlying "git apply" machinery, failing the application. > > Hm. I'll double check mail headers before sending out the next iteration.
I've changed my mutt configuration to prefer UTF-8 over ISO-8859-1, so the next iteration should hopefully work alright. But as you say, this is probably something that needs to be fixed in the git-am(1) machinery.
Patrick