Re: [PATCH 0/5] add-ons for ps/leakfixes

From: Patrick Steinhardt <ps@pks.im>
Date: May 30, 2024, 07:05 UTC
Message-ID: <ZlglMCI3GrN28A_R@tanuki>
In-Reply-To: <20240530063857.GA1942535@coredump.intra.peff.net>

On Thu, May 30, 2024 at 02:38:57AM -0400, Jeff King wrote:

Show 9 quoted lines

> Here are a few patches to go on top of ps/leakfixes. Patches 1 and 3 fix
> functional problems noticed by Coverity, and then the others are just
> cleanups I noticed while there.
> 
>   [1/5]: t-strvec: use va_end() to match va_start()
>   [2/5]: t-strvec: mark variable-arg helper with LAST_ARG_MUST_BE_NULL
>   [3/5]: mv: move src_dir cleanup to end of cmd_mv()
>   [4/5]: mv: factor out empty src_dir removal
>   [5/5]: mv: replace src_dir with a strvec

Thanks for the follow up, and thank especially for improving builtin/mv.c a bit further. The patches all look good to me.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.