Re: What's cooking in git.git (Jun 2016, #01; Thu, 2)

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 3, 2016, 23:47 UTC
Message-ID: <xmqqvb1pzvfu.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160603232653.GA24538@glandium.org>

Mike Hommey <mh@glandium.org> writes:

> In fact, the parser doesn't even reject the one that is considered
> invalid (the first).

My question was what the desired behaviour is, and if your "fix" gives us that desired outcome.

> (Also, the discussion back then was about
> git://[example.com:123]:/path/to/repo, not
> git://[example.com:123]/path/to/repo)

I thought these two ought to be equivalent:

	<scheme>://<host>:/<localpart>
	<scheme>://<host>/<localpart>

so the distinction shouldn't matter, no?

The former's last colon is "I wanted to write a custom port, but didn't spell it out, which is equivalent to spelling out the default port, which in turn is equivalent to not having that :<port> at all.