Re: What's cooking in git.git (Jun 2016, #01; Thu, 2)

From: Mike Hommey <mh@glandium.org>
Date: Jun 2, 2016, 23:13 UTC
Message-ID: <20160602231315.GA22864@glandium.org>
In-Reply-To: <xmqqa8j3ryo6.fsf@gitster.mtv.corp.google.com>

On Thu, Jun 02, 2016 at 03:52:41PM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> * mh/connect (2016-06-01) 9 commits
>  - connect: move ssh command line preparation to a separate function
>  - connect: actively reject git:// urls with a user part
>  - connect: change the --diag-url output to separate user and host
>  - connect: make parse_connect_url() return the user part of the url as a separate value
>  - connect: group CONNECT_DIAG_URL handling code
>  - connect: make parse_connect_url() return separated host and port
>  - connect: re-derive a host:port string from the separate host and port variables
>  - connect: call get_host_and_port() earlier
>  - connect: document why we sometimes call get_port after get_host_and_port
> 
>  Needs review.

I /think/ Torsten reviewed it all, and his last comments are in $gmane/295800. It's still not clear to me why he wants to remove the comment about [].

Mike