Re: [PATCH v2] i18n: notes: mark comment for translation
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 26, 2016, 17:05 UTC
- Message-ID
- <xmqqvazs1g9o.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1469535363.1845.8.camel@sapo.pt>
Vasco Almeida <vascomalmeida@sapo.pt> writes:
Show 21 quoted lines
> A Seg, 25-07-2016 às 10:49 -0700, Junio C Hamano escreveu:
>> Vasco Almeida <vascomalmeida@sapo.pt> writes:
>>
>> >
>> > static const char note_template[] =
>> > - "\nWrite/edit the notes for the following object:\n";
>> > + N_("Write/edit the notes for the following object:");
>>
>> I do not quite understand why you want the blank lines surrounding
>> the message outside add_commented_lines() call. I think the intent
>> is to produce
>>
>> #
>> # Write/edit the notes for the following object:
>> #
>
> Yes, this was my intention. The original does:
>
> #
> # Write/edit the notes for the following object:
> ____Ah, of course, I misspoke. The original "\n<message>\n" requests that an empty line that is commented, followed by a line with the message that is also commented, is given at that point. The last commented blank was my mistake.
In any case, I do not understand why you want to exclude the LFs from the message. If a translation for a particular language is very long and would not fit on a single line, the translator is allowed to make the message much longer, i.e. the translated version of the <message> part may contain one or more LFs (which is what the add-commented-lines function was invented for). I'd think having LFs in the to-be-translated-original will serve as a good hint to signal translators that is the case.
Thansk.