git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3] i18n: notes: mark comment for translation

From
Vasco Almeida <vascomalmeida@sapo.pt>
Date
Jul 26, 2016, 12:16 UTC
Message-ID
<1469535400-9242-1-git-send-email-vascomalmeida@sapo.pt>
In-Reply-To
<1469283027-23055-1-git-send-email-vascomalmeida@sapo.pt>
Mark comment displayed when editing a note for translation.
Signed-off-by: Vasco Almeida <vascomalmeida@sapo.pt>
---
 builtin/notes.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/builtin/notes.c b/builtin/notes.c
index 0572051..aec427b 100644
--- a/builtin/notes.c
+++ b/builtin/notes.c
@@ -91,7 +91,7 @@ static const char * const git_notes_get_ref_usage[] = {
 };
 
 static const char note_template[] =
-	"\nWrite/edit the notes for the following object:\n";
+	N_("Write/edit the notes for the following object:");
 
 struct note_data {
 	int given;
@@ -179,8 +179,9 @@ static void prepare_note_data(const unsigned char *object, struct note_data *d,
 			copy_obj_to_fd(fd, old_note);
 
 		strbuf_addch(&buf, '\n');
-		strbuf_add_commented_lines(&buf, note_template, strlen(note_template));
-		strbuf_addch(&buf, '\n');
+		strbuf_add_commented_lines(&buf, "\n", strlen("\n"));
+		strbuf_add_commented_lines(&buf, _(note_template), strlen(_(note_template)));
+		strbuf_add_commented_lines(&buf, "\n", strlen("\n"));
 		write_or_die(fd, buf.buf, buf.len);
 
 		write_commented_object(fd, object);
-- 
2.7.4
Previous: Vasco AlmeidaNext: Junio C Hamano
Message 6 of 11 in “i18n: notes: mark comment for translation”
  1. i18n: notes: mark comment for translationVasco Almeida, Jul 23, 2016
  2. Junio C HamanoJul 25, 2016
  3. Vasco AlmeidaJul 26, 2016
  4. Junio C HamanoJul 26, 2016
  5. Vasco AlmeidaJul 27, 2016
  6. i18n: notes: mark comment for translationVasco Almeida, Jul 26, 2016
  7. Junio C HamanoJul 26, 2016
  8. Vasco AlmeidaJul 27, 2016
  9. Junio C HamanoJul 27, 2016
  10. i18n: notes: mark comment for translationVasco Almeida, Jul 28, 2016
  11. Junio C HamanoJul 28, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.