Re: [PATCH v2] i18n: notes: mark comment for translation

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 25, 2016, 17:49 UTC
Message-ID: <xmqqr3ah621l.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1469283027-23055-1-git-send-email-vascomalmeida@sapo.pt>

Vasco Almeida <vascomalmeida@sapo.pt> writes:

Show 13 quoted lines

>  static const char note_template[] =
> -	"\nWrite/edit the notes for the following object:\n";
> +	N_("Write/edit the notes for the following object:");
>  
>  struct note_data {
>  	int given;
> @@ -179,7 +179,8 @@ static void prepare_note_data(const unsigned char *object, struct note_data *d,
>  			copy_obj_to_fd(fd, old_note);
>  
>  		strbuf_addch(&buf, '\n');
> -		strbuf_add_commented_lines(&buf, note_template, strlen(note_template));
> +		strbuf_addch(&buf, '\n');
> +		strbuf_add_commented_lines(&buf, _(note_template), strlen(_(note_template)));

I do not quite understand why you want the blank lines surrounding the message outside add_commented_lines() call. I think the intent is to produce

    #
    # Write/edit the notes for the following object:
    #

with the single call. If you pushed the newlines outside the message, wouldn't you end up having this instead (____ denoting an extra empty line each before and after the message)?

    ____
    # Write/edit the notes for the following object:
    ____