Re: [PATCH v7 3/6] pack-redundant: new algorithm to find min packs
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 31, 2019, 19:30 UTC
- Message-ID
- <xmqqva241v6d.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20190130114736.30357-4-worldhello.net@gmail.com>
Jiang Xin <worldhello.net@gmail.com> writes:
Show 6 quoted lines
> From: Sun Chao <sunchao9@huawei.com> > > When calling `git pack-redundant --all`, if there are too many local > packs and too many redundant objects within them, the too deep iteration > of `get_permutations` will exhaust all the resources, and the process of > `git pack-redundant` will be killed.
Build each step of the series with "make DEVELOPER=YesPlease" and your compiler hopefully would notice...
CC builtin/pack-redundant.o
builtin/pack-redundant.c:347:12: error: 'is_superset' defined but not used [-Werror=unused-function]
static int is_superset(struct pack_list *pl, struct llist *list)
^~~~~~~~~~~
builtin/pack-redundant.c:313:21: error: 'get_permutations' defined but not used [-Werror=unused-function]
static struct pll * get_permutations(struct pack_list *list, int n)
^~~~~~~~~~~~~~~~
builtin/pack-redundant.c:293:13: error: 'pll_free' defined but not used [-Werror=unused-function]
static void pll_free(struct pll *l)
^~~~~~~~
cc1: all warnings being treated as errors
Makefile:2302: recipe for target 'builtin/pack-redundant.o' failed
make: *** [builtin/pack-redundant.o] Error 1