Re: [PATCH v7 3/6] pack-redundant: new algorithm to find min packs
- From
Jiang Xin <worldhello.net@gmail.com>
- Date
- Feb 1, 2019, 09:55 UTC
- Message-ID
- <CANYiYbGpz57J9wY6+O17jgYw7rwnEr7=X73+_O61J_Cp+fVRyg@mail.gmail.com>
- In-Reply-To
- <xmqqva241v6d.fsf@gitster-ct.c.googlers.com>
Junio C Hamano <gitster@pobox.com> 于2019年2月1日周五 上午3:30写道:
Show 27 quoted lines
> > Jiang Xin <worldhello.net@gmail.com> writes: > > > From: Sun Chao <sunchao9@huawei.com> > > > > When calling `git pack-redundant --all`, if there are too many local > > packs and too many redundant objects within them, the too deep iteration > > of `get_permutations` will exhaust all the resources, and the process of > > `git pack-redundant` will be killed. > > Build each step of the series with "make DEVELOPER=YesPlease" and > your compiler hopefully would notice... > > CC builtin/pack-redundant.o > builtin/pack-redundant.c:347:12: error: 'is_superset' defined but not used [-Werror=unused-function] > static int is_superset(struct pack_list *pl, struct llist *list) > ^~~~~~~~~~~ > builtin/pack-redundant.c:313:21: error: 'get_permutations' defined but not used [-Werror=unused-function] > static struct pll * get_permutations(struct pack_list *list, int n) > ^~~~~~~~~~~~~~~~ > builtin/pack-redundant.c:293:13: error: 'pll_free' defined but not used [-Werror=unused-function] > static void pll_free(struct pll *l) > ^~~~~~~~ > cc1: all warnings being treated as errors > Makefile:2302: recipe for target 'builtin/pack-redundant.o' failed > make: *** [builtin/pack-redundant.o] Error 1 >
These unused code are deleted in another, and will be squashed to previous patch in next reroll.