Re: [PATCH/RFC v2 1/1] test-lint: Only use only sed [-n] [-e command] [-f command_file]
- From
Torsten Bögershausen <tboegi@web.de>
- Date
- Jan 25, 2019, 19:12 UTC
- Message-ID
- <20190125191224.pgugeqskuhzi34hv@tb-raspi4>
- In-Reply-To
- <xmqq8szbcl9q.fsf@gitster-ct.c.googlers.com>
On Wed, Jan 23, 2019 at 09:54:25AM -0800, Junio C Hamano wrote:
Show 11 quoted lines
> Torsten Bögershausen <tboegi@web.de> writes: > > >> I'd still prefer to see a more terse[1] (and not capitalized) message > >> to be consistent with existing error messages and to keep the reported > >> errors more compact overall to make them easier to digest[2,3]: > >> > >> err 'sed option not portable (use only -n, -e, -f)' > > > > That's OK for me - lets see if there are more comments. > > Thanks, both. Eric's proposed message looks good to me too.
Do you want to ammend the patch locally ? Or should I send a new version ?