git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: GIT_COMMITTER_* and reflog

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 26, 2019, 07:34 UTC
Message-ID
<xmqqv9scark1.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20191026022039.GE39574@google.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
> If GIT_COMMITTER_{NAME,EMAIL} were used when writing reflogs but
> GIT_COMMITTER_DATE weren't, would that help with your workflow?
Thanks for a thoughtful response.

My knee-jerk reaction is that it probably was a design bug that came out of laziness that we used the usual mechanism to obtain the committer date when deciding the timestamp we leave in reflog entries. Given that we say master@{6.hours.ago} etc., we should base the timestamp on something that is coherent with what the end users would give us, e.g. "6.hours.ago". IOW, we should be using the wallclock time without paying attention to GIT_COMMITTER_DATE, i.e. date.c::get_time().

Previous: Philip OakleyNext: Jeff King
Message 5 of 9 in “GIT_COMMITTER_* and reflog”
  1. Luke DashjrOct 25, 2019
  2. Jonathan NiederOct 26, 2019
  3. Luke DashjrOct 26, 2019
  4. Philip OakleyNov 7, 2019
  5. Junio C HamanoOct 26, 2019
  6. Jeff KingOct 26, 2019
  7. Junio C HamanoOct 27, 2019
  8. Phillip WoodOct 29, 2019
  9. Jeff KingOct 29, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.